Hi Olivier,
Your patch 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file
names' has broken the FVP build in a non-trivial way:
This part of the FDF:
"""
!ifdef $(DTB_DIR)
#
# Embed flattened device tree (FDT) images for all known
# variants of this platform
#
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2) {
$(DTB_DIR)/fvp-base-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV2Legacy) {
$(DTB_DIR)/fvp-base-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpBaseAEMv8x4GicV3) {
$(DTB_DIR)/fvp-base-gicv3-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2) {
$(DTB_DIR)/fvp-foundation-gicv2-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV2Legacy) {
$(DTB_DIR)/fvp-foundation-gicv2legacy-psci.dtb
}
FILE RAW = PCD (gArmVExpressTokenSpaceGuid.PcdFdtFvpFoundationGicV3) {
$(DTB_DIR)/fvp-foundation-gicv3-psci.dtb
}
!endif
"""
now generates build failures when DTB_DIR is set, and there is no easy
fix since the PCDs were removed and the underlying functionality as
well.
Since the patch has not been sent to the list for review, may I
propose that you revert it? Then we can discuss an approach for the
underlying issue rather than paper over the problems it has created.
Thanks,
Ard.
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
