On 07/08/15 10:16, Ard Biesheuvel wrote:
> On 8 July 2015 at 08:24, jiaxinwu <jiaxin...@intel.com> wrote:
>> Version2 update with a proper commit message.
>>
>
> This commit message still does not explain the purpose of this change.
I agree absolutely.
The commit message should be as follows, in *every single* patch that
touches a package in this manner:
<PackageName>: remove Ip4ConfigDxe module from the build
Ip4ConfigDxe used to provide the Ip4Config protocol, on which many
of the network drivers (used in this package) had traditionally
depended.
Since git commit 1f6729ff (SVN r17853), subject
MdeModulePkg: Update Ip4Dxe driver to support Ip4Config2 protocol
the Ip4Dxe driver itself provides a new version of the same
protocol: Ip4Config2. Dependent network drivers, libraries and
applications have been migrated to (or extended to) the new
protocol version.
For example:
- git 7c25b7ea (SVN r17869): ping & ifconfig
- git 00a6ad1b (SVN r17870): UefiHandleParsingLib
- git 6c5c70d6 (SVN r17873): DxeNetLib
- git 39561686 (SVN r17874): IpSecDxe
- git c581e503 (SVN r17875): EfiSocketLib
At this point, no driver, library or application in the edk2 tree
remains with a dependency (or an exclusive dependency) on the old
Ip4Config protocol. Therefore we can remove the providing driver,
Ip4ConfigDxe, from this build.
Jiaxin, please submit a v3 of the series, with this commit message in
each relevant patch. (Please don't forget to customize <PackageName> in
the subject line as appropriate.)
Thanks
Laszlo
>
>> Cc: Laszlo Ersek <ler...@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: jiaxinwu <jiaxin...@intel.com>
>> ---
>> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
>> ArmVirtPkg/ArmVirtQemu.fdf | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index 7ec0de4..6f47d8e 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -364,11 +364,10 @@
>> # Networking stack
>> #
>> MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
>> MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
>> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
>> - MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf
>> MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
>> MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
>> MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
>> MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
>> MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
>> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf
>> index e822fdf..4448018 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.fdf
>> +++ b/ArmVirtPkg/ArmVirtQemu.fdf
>> @@ -181,11 +181,10 @@ READ_LOCK_STATUS = TRUE
>> # Networking stack
>> #
>> INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
>> INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
>> INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
>> - INF MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf
>> INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
>> INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
>> INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
>> INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
>> INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
>> --
>> 1.9.5.msysgit.1
>>
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel
