On 07/08/15 09:21, Wu, Jiaxin wrote: > For question1: I have really add the commit message in v2 > patches(highlight below). Did I misunderstand?
You added a description to the cover letter (email 0/7), but whatever you write there will never reach the repo commit log, because the 0/7 email (the cover letter) is not a *patch*, therefore it cannot be committed. As I said for v3, if you perform the same update for N separate top-level packages, then the reasoning needs to be spelled out N times, separately. Someone might run git log -- OvmfPkg/ and the output will contain only patches (commit messages) that overlap with OvmfPkg/. For that reason the full explanation should be available in the OvmfPkg-specific (and all the other pkg-specific) patches too. > For question2: Maybe the cc part maintainers in commit message will be > ignored by edk2-devel if the maintainers already in edk2-devel mailing > list. That's correct, yes -- unfortunately, the edk2-mailing list has crazy settings. If you send an email To: the list, and Cc: a maintainer, but the maintainer is also subscribed, then emails *reflected* from the list server will drop the Cc: header. That is a terrible practice, because followups posted to the *reflected* message will have no chance to Cc: the maintainer! > If so, we need to specify the maintainers with “--to xxx” in git bash. Don't bother, I think your posting was fine (I received personal copies in my INBOX); it's just that edk2-devel is beyond repair. (I hope the new list will get this right.) Thanks Laszlo > > > > > > *From:*Ryan Harkin [mailto:ryan.har...@linaro.org] > *Sent:* Wednesday, July 8, 2015 2:44 PM > *To:* edk2-devel@lists.sourceforge.net > *Subject:* Re: [edk2] [PATCH v2 0/7] Remove Ip4ConfigDxe module and > related guid definitions from related packages. > > > > Thanks for updating, but perhaps I am reading the wrong thing. I don't > see a commit message in any of the v2 patches describing what you are > doing, like in your previous message on this thread. > > Also, you've added "CC: <someone>" to the commit message, but you > haven't actually CC'd the maintainers in question. So they might miss > your change. > > > > On 8 July 2015 at 07:24, jiaxinwu <jiaxin...@intel.com > <mailto:jiaxin...@intel.com>> wrote: > > Version2 update with a proper commit message. > Those patches are used to remove Ip4ConfigDxe module and related > guid definitions from related packages. > Ip4ConfigDxe driver is deprecated in UEFI 2.5, so we will not > support original Ip4Config Protocol, which is replace by Ip4Config2 > Protocol integrated in Ip4Dxe driver. > Related packages(MdeModulePkg, Nt32Pkg, ArmPlatformPkg, ArmVirtPkg, > EmulatorPkg, OvmfPkg, Vlv2TbltDevicePkg) need to remove Ip4ConfigDxe > module and related guid definitions. > > > jiaxinwu (7): > MdeModulePkg: Remove Ip4ConfigDxe module and related guid definition > from MdeModulePkg. > Nt32Pkg: Remove Ip4ConfigDxe module from Nt32Pkg. > OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg. > ArmPlatformPkg: Remove Ip4ConfigDxe module from ArmPlatformPkg. > ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg. > EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg. > Vlv2TbltDevicePkg: Remove Ip4ConfigDxe module from Vlv2TbltDevicePkg. > > ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 1 - > .../ArmVExpressPkg/ArmVExpress-CTA15-A7.fdf | 1 - > .../ArmVExpressPkg/ArmVExpress-CTA9x4.fdf | 1 - > .../ArmVExpressPkg/ArmVExpress-RTSM-A15.fdf | 1 - > .../ArmVExpressPkg/ArmVExpress-RTSM-A15_MPCore.fdf | 1 - > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 - > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > ArmVirtPkg/ArmVirtQemu.fdf | 1 - > EmulatorPkg/EmulatorPkg.dsc | 1 - > EmulatorPkg/EmulatorPkg.fdf | 3 +- > MdeModulePkg/Include/Guid/Ip4ConfigHii.h | 25 - > MdeModulePkg/Include/Guid/NicIp4ConfigNvData.h | 70 -- > MdeModulePkg/MdeModulePkg.dec | 6 - > MdeModulePkg/MdeModulePkg.dsc | 1 - > .../Universal/Network/Ip4ConfigDxe/ComponentName.c | 165 ---- > .../Universal/Network/Ip4ConfigDxe/Ip4Config.c | 745 > ----------------- > .../Universal/Network/Ip4ConfigDxe/Ip4Config.h | 533 ------------ > .../Network/Ip4ConfigDxe/Ip4ConfigDriver.c | 505 ------------ > .../Network/Ip4ConfigDxe/Ip4ConfigDxe.inf | 91 --- > .../Network/Ip4ConfigDxe/Ip4ConfigDxe.uni | Bin 2700 -> 0 > bytes > .../Network/Ip4ConfigDxe/Ip4ConfigDxe.vfr | 89 -- > .../Network/Ip4ConfigDxe/Ip4ConfigDxeExtra.uni | Bin 1366 -> 0 > bytes > .../Network/Ip4ConfigDxe/Ip4ConfigDxeStrings.uni | Bin 3000 -> 0 > bytes > .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c | 909 > --------------------- > .../Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.h | 54 -- > .../Universal/Network/Ip4ConfigDxe/Ip4NvData.h | 48 -- > .../Network/Ip4ConfigDxe/NicIp4Variable.c | 319 -------- > .../Network/Ip4ConfigDxe/NicIp4Variable.h | 104 --- > Nt32Pkg/Nt32Pkg.dsc | 1 - > Nt32Pkg/Nt32Pkg.fdf | 1 - > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32.fdf | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.fdf | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/OvmfPkgX64.fdf | 1 - > Vlv2TbltDevicePkg/PlatformPkg.fdf | 1 - > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 1 - > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 - > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 - > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 - > 41 files changed, 1 insertion(+), 3688 deletions(-) > delete mode 100644 MdeModulePkg/Include/Guid/Ip4ConfigHii.h > delete mode 100644 MdeModulePkg/Include/Guid/NicIp4ConfigNvData.h > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/ComponentName.c > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.c > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.h > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDriver.c > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.inf > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.uni > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxe.vfr > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxeExtra.uni > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigDxeStrings.uni > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.c > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4ConfigNv.h > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4NvData.h > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.c > delete mode 100644 > MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.h > > -- > 1.9.5.msysgit.1 > > > > ------------------------------------------------------------------------------ > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > <mailto:edk2-devel@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/edk2-devel > > > > > > ------------------------------------------------------------------------------ > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel > ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
