On 7 July 2015 at 19:37, Ryan Harkin <ryan.har...@linaro.org> wrote: > Hi Ard, > > On 7 July 2015 at 13:22, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> >> On 6 July 2015 at 20:26, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> > This fixes an issue reported by Ryan Harkin where 32-bit ARM platforms >> > without >> > PSCI compliant firmware cannot be rebooted or powered off successfully >> > at >> > boot time. >> > >> > This is caused by a change which aimed to prevent system register >> > accesses at >> > runtime. These registers are not virtually remapped, so their >> > availability is >> > not guaranteed in that case. However, since the reboot/poweroff driver >> > now >> > uses PSCI unconditionally, these non-PSCI platforms break. >> > >> > This series addresses this regression by introducing a new system >> > register >> > access library which switches into a non-functional mode at runtime, and >> > wiring >> > it up for 32-bit VExpress platforms. >> > >> >> OK, I have tested these changes myself using the RTSM-A15 build under >> QEMU. >> >> @Ryan: it would be helpful if you could verify that it fixes the >> original problem as well. > > > Thanks, yes, this fixes the problem I found with TC2. I also tested it on > Juno and FVP AEMv8 and Foundation to make sure it all still worked - and it > does. > > Well, the FVP AEMv8 model reboots instead of shutting down, but that isn't > your fault ;-) > > Thanks for sorting this out so quickly. > > Tested-by: Ryan Harkin <ryan.har...@linaro.org> >
Hello Olivier, Are you picking this up? Any changes needed? Thanks, Ard. >> > >> > Ard Biesheuvel (3): >> > ArmPlatformPkg/ArmVExpressPkg: add ArmPlatformSysConfigLib for runtime >> > ArmVExpressPkg: use ArmVExpressSysConfigRuntimeLib by default >> > ArmVExpressPkg: use PSCI for system reset only on AARCH64 platforms >> > >> > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc >> > | 3 ++- >> > >> > ArmPlatformPkg/ArmVExpressPkg/Library/{ArmVExpressSysConfigLib/ArmVExpressSysConfig.c >> > => ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c} >> > | >> > 10 ++++++++++ >> > >> > ArmPlatformPkg/ArmVExpressPkg/Library/{ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf >> > => ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf} | 12 >> > +++++++----- >> > 3 files changed, 19 insertions(+), 6 deletions(-) >> > copy >> > ArmPlatformPkg/ArmVExpressPkg/Library/{ArmVExpressSysConfigLib/ArmVExpressSysConfig.c >> > => ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c} (93%) >> > copy >> > ArmPlatformPkg/ArmVExpressPkg/Library/{ArmVExpressSysConfigLib/ArmVExpressSysConfigLib.inf >> > => ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.inf} (65%) >> > >> > -- >> > 1.9.1 >> > > > ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel