On 07/13/15 18:36, Olivier Martin wrote: > PcdDefaultBootType has been removed when the embedded > Linux Loader has been removed from BdsLib. > The boot arguments (defined by PcdDefaultBootArgument) are > now always targetting EFI applications. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Olivier Martin <olivier.mar...@arm.com> > Reviewed-by: Ronald Cron <ronald.c...@arm.com> > --- > ArmVirtPkg/ArmVirtQemu.dsc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index fbc2b12..0d4f4b0 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -133,7 +133,6 @@ > gArmPlatformTokenSpaceGuid.PcdDefaultBootDescription|L"Linux (EFI stub) on > virtio31:hd0:part0" > > gArmPlatformTokenSpaceGuid.PcdDefaultBootDevicePath|L"VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003E000A00000000)/HD(1,MBR,0x00000000,0x3F,0x19FC0)/Image" > gArmPlatformTokenSpaceGuid.PcdDefaultBootArgument|"root=/dev/vda2 > console=ttyAMA0 earlycon uefi_debug" > - gArmPlatformTokenSpaceGuid.PcdDefaultBootType|0 > > # > # Settings for ARM BDS -- use the serial console (ConIn & ConOut). >
The declaration of "gArmPlatformTokenSpaceGuid.PcdDefaultBootType" is removed from "ArmPlatformPkg/ArmPlatformPkg.dec" in patch #5. Therefore, if someone were to build the ArmVirtQemu.dsc platform right at patch #5, it would break. I'd like to request the following: - First, please remove the code (driver, library, etc) that consumes PcdDefaultBootType. At this point the PCD becomes unused, code-wise, but the tree should build. - Second, please remove the PCD assignments from the DSC files across the tree. - Third, please drop the PCD declaration as last step. Thank you Laszlo ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
