Reviewed-by: Jaben Carsey <jaben.car...@intel.com> >-----Original Message----- >From: Olivier Martin [mailto:olivier.mar...@arm.com] >Sent: Tuesday, July 14, 2015 8:49 AM >To: Leif Lindholm >Cc: Brendan Jackman; edk2-devel@lists.sourceforge.net >Subject: Re: [edk2] [PATCH] ShellPkg: Increase PcdShellFileOperationSize > >Ooops, I actually I have just realized I sent the patch to the wrong >maintainer. > > >On 14/07/15 15:39, Leif Lindholm wrote: >> On Tue, Jul 14, 2015 at 02:59:00PM +0100, Olivier Martin wrote: >>> From: Brendan Jackman <brendan.jack...@arm.com> >>> >>> This improves performance for dumb filesystem drivers >>> as block sizes tend to be more 4Kb size than 1000bit >> OK, so serious nitpicking, but: >> >> 4KB and 1000 bytes. >> >> Change those, and >> Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> >> >>> size. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Brendan Jackman <brendan.jack...@arm.com> >>> Reviewed-by: Olivier Martin <olivier.mar...@arm.com> >>> --- >>> ShellPkg/ShellPkg.dec | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec >>> index 32c0aff..b2f6326 100644 >>> --- a/ShellPkg/ShellPkg.dec >>> +++ b/ShellPkg/ShellPkg.dec >>> @@ -100,7 +100,7 @@ >>> gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength|50|UINT8|0x00000009 >>> >>> ## This determines how many bytes are read out of files at a time for >>> file operations (type, copy, etc...) >>> - >>> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|1000|UINT32|0x0000000A >>> + >>> gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x1000|UINT32|0x0000000A >>> >>> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >>> ## This flag is used to control the protocols produced by the shell >>> -- >>> 2.1.1 >>> >>> >>> ------------------------------------------------------------------------------ >>> Don't Limit Your Business. Reach for the Cloud. >>> GigeNET's Cloud Solutions provide you with the tools and support that >>> you need to offload your IT needs and focus on growing your business. >>> Configured For All Businesses. Start Your Cloud Today. >>> https://www.gigenetcloud.com/ >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/edk2-devel > > >-- IMPORTANT NOTICE: The contents of this email and any attachments are >confidential and may also be privileged. If you are not the >intended recipient, please notify the sender immediately and do not disclose >the contents to any other person, use it for any >purpose, or store or copy the information in any medium. Thank you. > >ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, >Registered in England & Wales, Company No: 2557590 >ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, >Registered in England & Wales, Company No: 2548782 > > >------------------------------------------------------------------------------ >Don't Limit Your Business. Reach for the Cloud. >GigeNET's Cloud Solutions provide you with the tools and support that >you need to offload your IT needs and focus on growing your business. >Configured For All Businesses. Start Your Cloud Today. >https://www.gigenetcloud.com/ >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/edk2-devel
------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
