On 07/16/15 04:09, Heyi Guo wrote: > There were some issues when I ran SCT test against Serial IO Protocol > on qemu aarch64, and below patches were made after I went through the > code of TerminalDxe driver and the flow of console devices being > connected. > > V2 is based on TTY terminal patches. > V3 updates comment for PcdDefaultTerminalType. > > Please help review these patches and provide your comments. > > Thanks. > > Heyi Guo (4): > MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType > ArmVirtPkg: Make terminal type consistent > MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default > MdeModulePkg/TerminalDxe: Some improvements > > ArmVirtPkg/ArmVirtQemu.dsc | 8 ++++++ > EmulatorPkg/EmulatorPkg.dsc | 2 +- > .../Universal/Console/TerminalDxe/Terminal.c | 29 > ++++------------------ > MdePkg/MdePkg.dec | 3 ++- > 4 files changed, 16 insertions(+), 26 deletions(-) >
When you send the next version of a patch series (any series), for each patch: - please pick up the Reviewed-by tags that you got for the patch in the last version, if the patch remains unchanged (or just trivially changed) - or else, if the patch has been changed significantly (or is new), then please document it either in the blurb, or use "git notes" to attach such notes (outside of the commit message) to the patch. (See also git-format-patch --notes.) For example, looking at [PATCH V3 2/4] ArmVirtPkg: Make terminal type consistent now, I got no clue if you changed that patch relative to v2 (which I reviewed), and if so, how. Therefore now I must save both versions of the patch (v2 and v3), compare them, and if I find that v3 is unchanged, or just trivially changed, I have to send Reviewed-by again. If you pick up tags for a repost, and point out the changes per patch, that saves a *lot* of time for reviewers. Thanks Laszlo ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
