On 07/14/15 18:48, Laszlo Ersek wrote: > Version 2 of > <http://thread.gmane.org/gmane.comp.bios.tianocore.devel/16304>. > > Changes relative to v1: > > - Since I received no feedback for Vlv2TbltDevicePkg, and no answer to > my explicit query about interest in Vlv2TbltDevicePkg, I dropped the > following v1 patches: > > 1/9 IntelFrameworkModulePkg: AcpiS3SaveDxe: prepare for End-of-Dxe > callback > 2/9 IntelFrameworkModulePkg: AcpiS3SaveDxe: call S3Ready() at > End-of-Dxe > 5/9 Vlv2TbltDevicePkg: replace AcpiS3Save->S3Save() with End-of-Dxe > signal > 8/9 IntelFrameworkModulePkg: AcpiS3SaveDxe: drop > EFI_ACPI_S3_SAVE_PROTOCOL > > The explanation is very simple: IntelFrameworkModulePkg/AcpiS3SaveDxe > and Vlv2TbltDevicePkg must be modified *together*. Since > Vlv2TbltDevicePkg is not being modified (see above), so can't > IntelFrameworkModulePkg/AcpiS3SaveDxe. > > The resultant status is valid for the entire tree, and it is also > explained in v2 4/6. > > - Incorporated v1 feedback; please see the notes section of each patch. > > Tested with S3 enabled and disabled, with Fedora and Windows Server 2012 > R2. > > The series compiles and works at each stage (including S3 suspend+resume > when it is enabled). > > Public branch: none ATM. The github repo is lagging behind SVN, and > without the most recent SVN commits, the series doesn't apply. It should > be no problem; we discussed repeatedly how to apply edk2 patches from > the mailing list. > > Thanks > Laszlo > > Ard Biesheuvel (1): > IntelFrameworkModulePkg/GenericBdsLib: remove AcpiS3->S3Save() call > > Laszlo Ersek (5): > OvmfPkg: AcpiS3SaveDxe: prepare for End-of-Dxe callback > OvmfPkg: AcpiS3SaveDxe: call S3Ready() at End-of-Dxe > OvmfPkg: PlatformBdsLib: signal End-of-Dxe event group > OvmfPkg: install DxeSmmReadyToLock in PlatformBdsLib > OvmfPkg: AcpiS3SaveDxe: drop EFI_ACPI_S3_SAVE_PROTOCOL > > IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf | 1 - > OvmfPkg/AcpiS3SaveDxe/AcpiS3SaveDxe.inf | 13 +- > OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf | 5 + > IntelFrameworkModulePkg/Library/GenericBdsLib/InternalBdsLib.h | 1 - > OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.h | 59 ------- > OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h | 4 + > IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c | 10 -- > OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c | 168 > +++++++------------- > OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 86 > ++++++++++ > 9 files changed, 154 insertions(+), 193 deletions(-) > delete mode 100644 OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.h >
Until the SVN outage at sourceforge.net gets resolved, we plan to commit patches that are ready for merging to the "master" branch of the git repository at <https://github.com/tianocore/edk2-svn-offline.git>. Please see the announcement: http://thread.gmane.org/gmane.comp.bios.edk2.devel/227 This particular patch (or series) appears ready for merging, therefore it is being picked up: http://thread.gmane.org/gmane.comp.bios.edk2.devel/227/focus=251 Further development should be based on edk2-svn-offline/master, until the SVN outage is fixed. At that point the accumulated patches will be mass-committed from edk2-svn-offline/master to SVN. Thanks Laszlo ------------------------------------------------------------------------------ _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
