Hi,

On 09/27/2017 10:04 AM, Jan Kiszka wrote:
On 2017-09-27 10:00, Claudius Heine wrote:
Hi Jan,

On 09/27/2017 09:34 AM, Jan Kiszka wrote:
On 2017-09-27 09:29, Jan Kiszka wrote:
On 2017-09-26 15:22, [ext] [email protected] wrote:
From: Claudius Heine <[email protected]>

This commit adds cppcheck as a travis target. Raised issues are
suppressed and should be fixed in further commits.

Signed-off-by: Claudius Heine <[email protected]>
---
   .travis-build.sh | 43 +++++++++++++++++++++++++++++++++++++++++++
   .travis.yml      |  1 +
   2 files changed, 44 insertions(+)

diff --git a/.travis-build.sh b/.travis-build.sh
index 56786ab..c1d16cd 100755
--- a/.travis-build.sh
+++ b/.travis-build.sh
@@ -10,6 +10,21 @@ prepare_build()
       mkdir build
       cd build
   }
+
+install_cppcheck()
+{
+    git clone https://github.com/danmar/cppcheck.git
+    cd cppcheck
+    git checkout 1.80
+    make SRCDIR=build CFGDIR=/usr/share/cppcheck HAVE_RULES=no -j2
+    sudo make install
+    # On travis cppcheck ignores CFGDIR. Instead, it looks in $PWD.
Compare
+    # strace output.
+    sudo install -m644 ./cfg/* ../
+    cd ..
+    rm -rf cppcheck
+}
+

Is anything that trusty (1.61 / 1.66) or xenial (1.72) provides in terms
of cppcheck too old? If yes, the build should not flood the logs with
tons of warnings like it does right now (not a good sign for this
cppversion version...).

Hmm... I prefer to have a fixed version, because results of cppcheck
vary a lot between versions.

Selecting one from a specific Ubuntu release provides you exactly this.
So, unless there is need to go for 1.80, let's go for a packaged version.

Installing cppcheck to travis is not so smooth:

  The following packages have unmet dependencies:
cppcheck : Depends: libstdc++6 (>= 5.2) but 4.8.4-2ubuntu1~14.04.3 is to be installed

I think I'll stay with building 1.80.

Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected]

--
You received this message because you are subscribed to the Google Groups "EFI Boot 
Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/a1a558f6-c1a8-7ec3-3646-8d54016ec135%40siemens.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to