Hi Jan,

On 09/27/2017 09:34 AM, Jan Kiszka wrote:
Looking at the (presumably) relevant output of the cppcheck run,

(information) Couldn't find path given by -I 'swupdate-adapter/'
[/usr/include/libio.h:49]: (information) Include file: <stdarg.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[/usr/include/stdio.h:83]: (information) Include file: <stdarg.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[include/env_api.h:20]: (information) Include file: <stdbool.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[/usr/include/wchar.h:39]: (information) Include file: <stdarg.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[include/env_api.h:29]: (information) Include file: "config.h" not found.
[/usr/include/x86_64-linux-gnu/zconf.h:427]: (information) Include file: 
<stdarg.h> not found. Please note: Cppcheck does not need standard library 
headers to get proper results.
[/usr/include/bits/stdio-lock.h:23]: (information) Include file: 
<lowlevellock.h> not found. Please note: Cppcheck does not need standard 
library headers to get proper results.
[include/ebgpart.h:43]: (information) Include file: <stdbool.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[/usr/include/wchar.h:88]: (information) Skipping configuration 
'_GLIBCPP_USE_NAMESPACES;__WINT_TYPE__;_WINT_T;__WINT_TYPE__' since the value 
of '__WINT_TYPE__' is unknown. Use -D if you want to check it. You can use -U 
to skip it explicitly.
[/usr/include/wchar.h:88]: (information) Skipping configuration 
'_WINT_T;__WINT_TYPE__' since the value of '__WINT_TYPE__' is unknown. Use -D 
if you want to check it. You can use -U to skip it explicitly.
[/usr/include/wchar.h:88]: (information) Skipping configuration '__WINT_TYPE__' 
since the value of '__WINT_TYPE__' is unknown. Use -D if you want to check it. 
You can use -U to skip it explicitly.
[tools/tests/test_api.c:14]: (information) Include file: <stdarg.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[tools/tests/test_api.c:16]: (information) Include file: <stdbool.h> not found. 
Please note: Cppcheck does not need standard library headers to get proper results.
[tools/tests/test_environment.c:14]: (information) Include file: <stdarg.h> not 
found. Please note: Cppcheck does not need standard library headers to get proper 
results.
[tools/tests/test_environment.c:16]: (information) Include file: <stdbool.h> 
not found. Please note: Cppcheck does not need standard library headers to get proper 
results.
[tools/tests/test_partitions.c:14]: (information) Include file: <stdarg.h> not 
found. Please note: Cppcheck does not need standard library headers to get proper 
results.
[tools/tests/test_partitions.c:16]: (information) Include file: <stdbool.h> not 
found. Please note: Cppcheck does not need standard library headers to get proper 
results.

it seems there is still some work needed to fine tune the setting prior
to activating this.

I am currently preparing the new patch. But here is a questions about suppressing the found issues.

How should I proceed:

- Don't suppress any non-obvious issues and fix or suppress them in later patches.

  - Suppress all found issues and fix or justify them in later patches.

In this patchset I tried the second option, but Andreas prefered the first one. Chooseing the first one would be easier for me, but travis will show that the build failed until all issues are resolved one way or another.

Our input?

Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected]

--
You received this message because you are subscribed to the Google Groups "EFI Boot 
Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/9bfcd836-bb4c-bd03-7e29-e5aeb8859b9d%40siemens.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to