Hi, On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > From: Andreas Reichel <[email protected]> > > For unit test support, code must be more modular. > This also avoids inline functions and static functions where > possible.
I skip reviewing this patch because I assume this patch does not modify any code, just moves it into separate files? Otherwise I would rather see one patch that changes stuff and one patch that moves stuff. If you removed 'static' keywords, them maybe do it in a separate patch. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected] PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/1508855275.13007.43.camel%40denx.de. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: This is a digitally signed message part
