On Tue, Oct 24, 2017 at 06:27:48PM +0200, Claudius Heine wrote: > Hi, > > On Tue, 2017-10-24 at 17:42 +0200, Andreas Reichel wrote: > > On Tue, Oct 24, 2017 at 04:27:55PM +0200, Claudius Heine wrote: > > > Hi, > > > > > > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > > > From: Andreas Reichel <[email protected]> > > > > > > > > For unit test support, code must be more modular. > > > > This also avoids inline functions and static functions where > > > > possible. > > > > > > I skip reviewing this patch because I assume this patch does not > > > modify > > > any code, just moves it into separate files? Otherwise I would > > > rather > > > see one patch that changes stuff and one patch that moves stuff. > > > > > > If you removed 'static' keywords, them maybe do it in a separate > > > patch. > > > > > > > Sorry this is complete nonsense to me. If I move local code into > > separated translation units, it is implicit, that I have to remove > > static keywords. There is no use in creating a patch overkill by just > > removing static keywoards. > > IMO that eases review, does it not? 1 remove statics with a commit > messages that hints to the next patch and 2 split stuff up and don't > change code. > Removing static keywoards is nothing that can break code and nothing that needs deeper review.
> I don't think its good practice to try to have fewer patches by doing > multiple different things in one patch. But I get that you think that > those things aren't two steps and I think they are, so maybe Jan should > decide. These ARE things belonging together here :) These are not different things. Yes, Jan please decide :) Andreas > > Claudius > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected] > > PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 > Keyserver: hkp://pool.sks-keyservers.net > > -- > You received this message because you are subscribed to the Google Groups > "EFI Boot Guard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/1508862468.13007.95.camel%40denx.de. > For more options, visit https://groups.google.com/d/optout. -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant [email protected], +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082 -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/20171025085653.GC19902%40iiotirae. For more options, visit https://groups.google.com/d/optout.
