On 2017-11-15 17:11, Claudius Heine wrote:
> Hi,
>
> On 11/15/2017 09:09 AM, [ext] Claudius Heine wrote:
>> Hi,
>>
>> On 11/15/2017 07:56 AM, [ext] Jan Kiszka wrote:
>>> From: Jan Kiszka <[email protected]>
>>>
>>> Improve the consistency of our coding style use, mostly around
>>> encapsulating even single-line-blocks in braces and avoiding assignments
>>> in if statements.
>>
>> I already have some kind of clang-format style check implemented in
>> travis[1]. The output format needs to be improved though.
>
> I tried to improve this format reporting a bit. This is the current result:
>
> https://travis-ci.org/cmhe/efibootguard/jobs/302559792
>
> Maybe we have to improve/relax the clang format rules a bit and add
> suppress it in some code fragments.
>
> What do you think?
./main.c:54
orig: b'\tif (EFI_ERROR(status))\n\t\treturn status;'
repl: b'\tif (EFI_ERROR(status)) return status;'
./main.c:108
orig: b'\tPrint(L"\\nEFI Boot Guard %s\\n", L""EFIBOOTGUARD_VERSION);'
repl: b'\tPrint(L"\\nEFI Boot Guard %s\\n", L"" EFIBOOTGUARD_VERSION);'
./include/ebgenv.h:20
orig: b'#define USERVAR_TYPE_CHAR\t\t1'
repl: b'#define USERVAR_TYPE_CHAR 1'
Err, not yet quite there...
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
--
You received this message because you are subscribed to the Google Groups "EFI
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/efibootguard-dev/c463f027-8eb0-d258-6071-46c32d52a1c9%40siemens.com.
For more options, visit https://groups.google.com/d/optout.
