Hi Jan, On Thu, 2017-11-16 at 18:25 +0100, Jan Kiszka wrote: > On 2017-11-15 17:11, Claudius Heine wrote: > > Hi, > > > > On 11/15/2017 09:09 AM, [ext] Claudius Heine wrote: > > > Hi, > > > > > > On 11/15/2017 07:56 AM, [ext] Jan Kiszka wrote: > > > > From: Jan Kiszka <[email protected]> > > > > > > > > Improve the consistency of our coding style use, mostly around > > > > encapsulating even single-line-blocks in braces and avoiding > > > > assignments > > > > in if statements. > > > > > > I already have some kind of clang-format style check implemented > > > in > > > travis[1]. The output format needs to be improved though. > > > > I tried to improve this format reporting a bit. This is the current > > result: > > > > https://travis-ci.org/cmhe/efibootguard/jobs/302559792 > > > > Maybe we have to improve/relax the clang format rules a bit and add > > suppress it in some code fragments. > > > > What do you think? > > ./main.c:54 > orig: b'\tif (EFI_ERROR(status))\n\t\treturn status;' > repl: b'\tif (EFI_ERROR(status)) return status;' > > ./main.c:108 > orig: b'\tPrint(L"\\nEFI Boot Guard %s\\n", > L""EFIBOOTGUARD_VERSION);' > repl: b'\tPrint(L"\\nEFI Boot Guard %s\\n", L"" > EFIBOOTGUARD_VERSION);' > > ./include/ebgenv.h:20 > orig: b'#define USERVAR_TYPE_CHAR\t\t1' > repl: b'#define USERVAR_TYPE_CHAR 1' > > Err, not yet quite there...
Yes the clang-format rules are strange. I haven't touched them yet. Hopefully its possible to relax them so that they ignore these kind of white space issues. My question was more about how those errors are presented and if we want to establish a definite style guide this way. The project is still young enough to try this IMO. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: [email protected] PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/1510871011.3306.39.camel%40denx.de. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: This is a digitally signed message part
