From: Jan Kiszka <[email protected]>

That error code was overwritting by the concluding BG_SUCCESS setting so
far. Found by cppcheck.

Signed-off-by: Jan Kiszka <[email protected]>
---
 env/fatvars.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/env/fatvars.c b/env/fatvars.c
index 99ac37e..81b4432 100644
--- a/env/fatvars.c
+++ b/env/fatvars.c
@@ -111,6 +111,8 @@ BG_STATUS load_config(BG_LOADER_PARAMS *bglp)
                goto lc_cleanup;
        }
 
+       result = BG_SUCCESS;
+
        if (numHandles < ENV_NUM_CONFIG_PARTS) {
                Print(L"Warning, too few config partitions: found: "
                      L"%d, but expected %d.\n",
@@ -227,7 +229,6 @@ BG_STATUS load_config(BG_LOADER_PARAMS *bglp)
        Print(L" args: %s\n", bglp->payload_options);
        Print(L" timeout: %d seconds\n", bglp->timeout);
 
-       result = BG_SUCCESS;
 lc_cleanup:
        mfree(config_volumes);
        return result;
-- 
2.26.2

-- 
You received this message because you are subscribed to the Google Groups "EFI 
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/50fc036777b329ee7a650a6b49390ef9146981de.1610179743.git.jan.kiszka%40siemens.com.

Reply via email to