From: Jan Kiszka <[email protected]>

cppcheck noted that some results are not properly evaluated. Easy to
fix.

Signed-off-by: Jan Kiszka <[email protected]>
---
 tools/tests/test_ebgenv_api.c          | 1 +
 tools/tests/test_ebgenv_api_internal.c | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/tools/tests/test_ebgenv_api.c b/tools/tests/test_ebgenv_api.c
index 12716a7..ea4523f 100644
--- a/tools/tests/test_ebgenv_api.c
+++ b/tools/tests/test_ebgenv_api.c
@@ -147,6 +147,7 @@ START_TEST(ebgenv_api_ebg_env_create_new)
         */
        ret = ebg_env_create_new(&e);
 
+       ck_assert_int_eq(ret, 0);
        ck_assert(((BGENV *)e.bgenv)->data == &envdata[0]);
        ck_assert_int_eq(((BGENV *)e.bgenv)->data->ustate, USTATE_OK);
        ck_assert_int_eq(
diff --git a/tools/tests/test_ebgenv_api_internal.c 
b/tools/tests/test_ebgenv_api_internal.c
index 1a5dfa0..795375f 100644
--- a/tools/tests/test_ebgenv_api_internal.c
+++ b/tools/tests/test_ebgenv_api_internal.c
@@ -306,10 +306,14 @@ START_TEST(ebgenv_api_internal_bgenv_get)
        /* Test if bgenv_get returns the correct value
         */
        res = bgenv_get(handle, "kernelfile", NULL, buffera, res);
+       ck_assert_int_eq(res, 0);
        ck_assert_int_eq(strcmp(buffera, test_strings[0]), 0);
 
        res = bgenv_get(handle, "kernelparams", NULL, NULL, 1000);
+       ck_assert_int_eq(res, strlen(test_strings[1]) + 1);
+
        res = bgenv_get(handle, "kernelparams", NULL, buffera, res);
+       ck_assert_int_eq(res, 0);
        ck_assert_int_eq(strcmp(buffera, test_strings[1]), 0);
 
        free(handle);
-- 
2.26.2

-- 
You received this message because you are subscribed to the Google Groups "EFI 
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/a23d5fc0c615cfd1d84975c17e7bcc2d88a2fa0f.1610179743.git.jan.kiszka%40siemens.com.

Reply via email to