This addresses the new cppcheck finding plus some reported locally. It also helps to perform such local checks more easily in the future by pulling out a cppcheck script.
Finally, this moves driver helper functions under drivers/utils and avoids including them when there is no driver that needs them. Jan Jan Kiszka (7): scripts: Factor out cppcheck.sh from CI job cppcheck: Add exception for new warning in w83627hf_wdt.c watchdog: ipmi_wdt: Avoid pointless check at loop entry libebgenv: Address cppcheck style complaint cppcheck: Suppress unusedStructMember in kernel-stub/fdt.c drivers: Move smbios helper out of utils into separate folder drivers: utils: Relocate simatic.c .github/workflows/main.yaml | 54 +-------------------- Makefile.am | 8 +++- simatic.c => drivers/utils/simatic.c | 1 + drivers/utils/smbios.c | 41 ++++++++++++++++ drivers/watchdog/ipmi_wdt.c | 7 +-- include/smbios.h | 21 ++++++++ include/utils.h | 3 -- scripts/cppcheck.sh | 72 ++++++++++++++++++++++++++++ tools/ebgpart.c | 7 ++- utils.c | 25 ---------- 10 files changed, 149 insertions(+), 90 deletions(-) rename simatic.c => drivers/utils/simatic.c (98%) create mode 100644 drivers/utils/smbios.c create mode 100644 include/smbios.h create mode 100755 scripts/cppcheck.sh -- 2.35.3 -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/cover.1697736989.git.jan.kiszka%40siemens.com.
