From: Jan Kiszka <[email protected]> This allows the local execution of cppcheck with the same parameters used in CI, specifically the same exceptions.
Signed-off-by: Jan Kiszka <[email protected]> --- .github/workflows/main.yaml | 54 +--------------------------- scripts/cppcheck.sh | 70 +++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+), 53 deletions(-) create mode 100755 scripts/cppcheck.sh diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 2b3a89e..11a3194 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -163,56 +163,4 @@ jobs: if: ${{ matrix.target == 'cppcheck' }} run: | ./configure - - ignore="" - ignore+=" -i tests/fff" - - suppress="" - # Justified suppressions: - # Does not belong to the project - suppress+=" --suppress=*:/usr/include/*" - suppress+=" --suppress=*:/usr/include/bits/*" - # Function 'efi_main' is called by efi: - suppress+=" --suppress=unusedFunction:main.c" - suppress+=" --suppress=unusedFunction:kernel-stub/main.c" - # Some functions are defined for API only - suppress+=" --suppress=unusedFunction:utils.c" - suppress+=" --suppress=unusedFunction:env/env_api.c" - suppress+=" --suppress=unusedFunction:env/fatvars.c" - suppress+=" --suppress=unusedFunction:tools/tests/test_environment.c" - suppress+=" --suppress=unusedFunction:env/env_api_fat.c" - # Some functions are used by linker wrapping - suppress+=" --suppress=unusedFunction:tools/tests/test_probe_config_file.c" - suppress+=" --suppress=unusedFunction:tools/tests/test_ebgenv_api.c" - # False positive on init_array iteration - suppress+=" --suppress=comparePointers:main.c" - # False positive on constructors, first hit - suppress+=" --suppress=unusedFunction:drivers/watchdog/amdfch_wdt.c" - # False positive, noreturn is not recognized - suppress+=" --suppress=nullPointerRedundantCheck:kernel-stub/main.c" - # Avoid noise regarding Ignore* fields - suppress+=" --suppress=unusedStructMember:kernel-stub/main.c" - # Not applicable because of API requirements - suppress+=" --suppress=constParameter:drivers/watchdog/ipc4x7e_wdt.c" - suppress+=" --suppress=constParameter:kernel-stub/initrd.c" - - enable="--enable=warning \ - --enable=style \ - --enable=performance \ - --enable=portability \ - --enable=unusedFunction" - - includes="-I . \ - -I include \ - -I /usr/include \ - -I /usr/include/linux \ - -I /usr/include/efi \ - -I /usr/include/efi/x86_64 \ - -I /usr/include/x86_64-linux-gnu \ - -I /usr/lib/gcc/x86_64-linux-gnu/9/include" - - cpp_conf="-U__WINT_TYPE__ -U__GNUC__" - # Exit code '1' is returned if arguments are not valid or if no input - # files are provided. Compare 'cppcheck --help'. - cppcheck -f -q --error-exitcode=2 $enable $suppress $ignore \ - $cpp_conf $includes . + scripts/cppcheck.sh diff --git a/scripts/cppcheck.sh b/scripts/cppcheck.sh new file mode 100755 index 0000000..1267f21 --- /dev/null +++ b/scripts/cppcheck.sh @@ -0,0 +1,70 @@ +#!/bin/bash +# +# EFI Boot Guard +# +# Copyright (c) Siemens AG, 2021-2023 +# +# Authors: +# Claudius Heine <[email protected]> +# Jan Kiszka <[email protected]> +# +# This work is licensed under the terms of the GNU GPL, version 2. See +# the COPYING file in the top-level directory. +# +# SPDX-License-Identifier: GPL-2.0 +# + +ignore="" +ignore+=" -i tests/fff" + +suppress="" +# Justified suppressions: +# Does not belong to the project +suppress+=" --suppress=*:/usr/include/*" +suppress+=" --suppress=*:/usr/include/bits/*" +# Function 'efi_main' is called by efi: +suppress+=" --suppress=unusedFunction:main.c" +suppress+=" --suppress=unusedFunction:kernel-stub/main.c" +# Some functions are defined for API only +suppress+=" --suppress=unusedFunction:utils.c" +suppress+=" --suppress=unusedFunction:env/env_api.c" +suppress+=" --suppress=unusedFunction:env/fatvars.c" +suppress+=" --suppress=unusedFunction:tools/tests/test_environment.c" +suppress+=" --suppress=unusedFunction:env/env_api_fat.c" +# Some functions are used by linker wrapping +suppress+=" --suppress=unusedFunction:tools/tests/test_probe_config_file.c" +suppress+=" --suppress=unusedFunction:tools/tests/test_ebgenv_api.c" +# False positive on init_array iteration +suppress+=" --suppress=comparePointers:main.c" +# False positive on constructors, first hit +suppress+=" --suppress=unusedFunction:drivers/watchdog/amdfch_wdt.c" +# False positive, noreturn is not recognized +suppress+=" --suppress=nullPointerRedundantCheck:kernel-stub/main.c" +# Avoid noise regarding Ignore* fields +suppress+=" --suppress=unusedStructMember:kernel-stub/main.c" +# Not applicable because of API requirements +suppress+=" --suppress=constParameter:drivers/watchdog/ipc4x7e_wdt.c" +suppress+=" --suppress=constParameter:kernel-stub/initrd.c" + +enable="--enable=warning \ + --enable=style \ + --enable=performance \ + --enable=portability \ + --enable=unusedFunction" + +includes="-I . \ + -I include \ + -I /usr/include \ + -I /usr/include/linux \ + -I /usr/include/efi \ + -I /usr/include/efi/x86_64 \ + -I /usr/include/x86_64-linux-gnu \ + -I /usr/lib/gcc/x86_64-linux-gnu/9/include" + +cpp_conf="-U__WINT_TYPE__ -U__GNUC__" +path=${1-.} + +# Exit code '1' is returned if arguments are not valid or if no input +# files are provided. Compare 'cppcheck --help'. +cppcheck -f -q --error-exitcode=2 $enable $suppress $ignore \ + $cpp_conf $includes $path "$@" -- 2.35.3 -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/28f45dc2e28cb90fa253ae7553425e5e7cf76b7d.1697736989.git.jan.kiszka%40siemens.com.
