On 14.11.23 10:25, Root Mailer wrote: > Have ITCO_V6 watchdogs already been tested successfully with ebg? >
On two of our IPCs at least, one Elkhart Lake, one Tiger Lake based. > On Monday, November 13, 2023 at 11:13:06 PM UTC+1 Root Mailer wrote: > > You mean we need a > > .pmc_no_reboot_mask = (1 << 2), > > here for ITCO_V6: > > > https://github.com/siemens/efibootguard/blob/master/drivers/watchdog/itco.c#L107 > > <https://github.com/siemens/efibootguard/blob/master/drivers/watchdog/itco.c#L107> > The problem may indeed be that we are hard-coding tco_base here. That's why I suggested to compare register addresses that both drivers use on the device. Jan > as in the kernel here: > > > https://elixir.bootlin.com/linux/v6.7-rc1/source/drivers/watchdog/iTCO_wdt.c#L165 > > <https://elixir.bootlin.com/linux/v6.7-rc1/source/drivers/watchdog/iTCO_wdt.c#L165> > > On Friday, November 10, 2023 at 7:57:55 PM UTC+1 Jan Kiszka wrote: > > On 09.11.23 15:55, Root Mailer wrote: > > Yes in Linux it seems to work. We tested this by following the > guide in > > [1]. When we cat to the /dev/watchdog0 device the system > reboots after > > 30 seconds. > > > > [1] > > > > https://www.thomas-krenn.com/de/wiki/Watchdog#Testen_der_Watchdog_Funktion > <https://www.thomas-krenn.com/de/wiki/Watchdog#Testen_der_Watchdog_Funktion> > > > > Then something is wrong with what the EBG driver does, possibly > around > clearing the no-reboot flag. Someone near to a hardware would > have to > sit down and compare, e.g. if EBG is using the same addresses > for that > flag change as Linux does. > > Jan > > > On Thursday, November 9, 2023 at 2:19:31 PM UTC+1 Jan Kiszka > wrote: > > > > On 08.11.23 14:51, Root Mailer wrote: > > > Watchdog is now (allegedly) supported, thanks for that. > > Unfortunately, > > > it does not work as expected. > > > > > > We set watchdog timeout to 30 seconds via "bg_setenv --part=0/1 > > > --watchdog=30". Looks good: > > > > > > Screenshot from 2023-11-08 10-02-55.png > > > > > > We then manipulated the bzImage and the part where > > bg_gen_unified_kernel > > > checks for a valid bzImage to simulate a non-working kernel > here: > > > > > > > > > > https://github.com/siemens/efibootguard/blob/master/tools/bg_gen_unified_kernel#L112 > > <https://github.com/siemens/efibootguard/blob/master/tools/bg_gen_unified_kernel#L112> > > <https://github.com/siemens/efibootguard/blob/master/tools/bg_gen_unified_kernel#L112 > > <https://github.com/siemens/efibootguard/blob/master/tools/bg_gen_unified_kernel#L112>> > > > > > > But the system does not reboot, it just hangs after the last > line EFI > > > stub: etc. Any ideas what's missing? > > > > > > > If you start the watchdog from Linux and let it expire there, > will the > > machine reboot in that case? If no, then we have a hardware or > firmware > > issue. If yes, then we could look for missing bits in the > Linux code. > > > > Jan > > > > -- > > Siemens AG, Technology > > Linux Expert Center > > > > -- > > You received this message because you are subscribed to the > Google > > Groups "EFI Boot Guard" group. > > To unsubscribe from this group and stop receiving emails from > it, send > > an email to efibootguard-d...@googlegroups.com > > <mailto:efibootguard-d...@googlegroups.com>. > > To view this discussion on the web visit > > > > https://groups.google.com/d/msgid/efibootguard-dev/b273b8d6-d84e-4709-8915-860113531e12n%40googlegroups.com > > <https://groups.google.com/d/msgid/efibootguard-dev/b273b8d6-d84e-4709-8915-860113531e12n%40googlegroups.com> > > <https://groups.google.com/d/msgid/efibootguard-dev/b273b8d6-d84e-4709-8915-860113531e12n%40googlegroups.com?utm_medium=email&utm_source=footer > > <https://groups.google.com/d/msgid/efibootguard-dev/b273b8d6-d84e-4709-8915-860113531e12n%40googlegroups.com?utm_medium=email&utm_source=footer>>. > > -- > Siemens AG, Technology > Linux Expert Center > > -- > You received this message because you are subscribed to the Google > Groups "EFI Boot Guard" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to efibootguard-dev+unsubscr...@googlegroups.com > <mailto:efibootguard-dev+unsubscr...@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/b59b4a09-0e4a-4c6b-9318-f7d41a216311n%40googlegroups.com > > <https://groups.google.com/d/msgid/efibootguard-dev/b59b4a09-0e4a-4c6b-9318-f7d41a216311n%40googlegroups.com?utm_medium=email&utm_source=footer>. -- Siemens AG, Technology Linux Expert Center -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to efibootguard-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/1bd10736-6cc9-4f41-a504-8f43aa9e0b19%40siemens.com.
