On 17.04.24 17:38, 'Mathieu Tetreault' via EFI Boot Guard wrote: > Signed-off-by: Mathieu Tetreault <math...@rmds.ca> > --- > drivers/watchdog/itco.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/itco.c b/drivers/watchdog/itco.c > index 9252014..c20b1b6 100644 > --- a/drivers/watchdog/itco.c > +++ b/drivers/watchdog/itco.c > @@ -40,6 +40,7 @@ enum iTCO_chipsets { > ITCO_INTEL_WBG, > ITCO_INTEL_EHL, > ITCO_INTEL_TLH, > + ITCO_INTEL_SUNRISE_LP, > }; > > enum iTCO_versions { > @@ -92,7 +93,12 @@ static const iTCO_regs iTCO_version_regs[] = { > }, > [ITCO_V4] = > { > - /* Not implemented yet */ > + .pmc_base_reg = 0x10, > + .pmc_reg = 0x1008, > + .pmc_no_reboot_mask = (1 << 4),
Is that correct? I'm comparing things here to linux/drivers/watchdog/iTCO_wdt.c, no_reboot_bit() which seems to deliver a mask, not a bit number. > + .pmc_base_addr_mask = 0xfffffe00, > + .pm_base_reg = 0x400, Minor: Indention is off here. > + .pm_base_addr_mask = 0x0000ff80, > }, > [ITCO_V5] = > { > @@ -163,6 +169,12 @@ static const iTCO_info iTCO_chipset_info[] = { > .pci_id = 0x43a3, > .itco_version = ITCO_V6, > }, > + [ITCO_INTEL_SUNRISE_LP] = > + { > + .name = L"Sunrise Point-LP", > + .pci_id = 0x9d23, > + .itco_version = ITCO_V4, > + }, > }; > > static BOOLEAN itco_supported(UINT16 pci_device_id, UINT8 *index) > @@ -320,6 +332,7 @@ static EFI_STATUS init(EFI_PCI_IO *pci_io, UINT16 > pci_vendor_id, > update_no_reboot_flag_cnt(tco_base); > break; > case ITCO_V5: > + case ITCO_V4: > update_no_reboot_flag_apl(itco); > break; > case ITCO_V3: Thanks for enabling this! Jan -- Siemens AG, Technology Linux Expert Center -- You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group. To unsubscribe from this group and stop receiving emails from it, send an email to efibootguard-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/6bbb4211-535c-4a21-9cb2-83ea1f4fd170%40siemens.com.