> On 21.04.24 21:44, Jan Kiszka wrote:
> > On 19.04.24 14:24, 'Mathieu Alexandre-Tetreault' via EFI Boot Guard wrote:
> >>>>  enum iTCO_versions {
> >>>> @@ -92,7 +93,12 @@ static const iTCO_regs iTCO_version_regs[] = {
> >>>>          },
> >>>>      [ITCO_V4] =
> >>>>          {
> >>>> -            /* Not implemented yet */
> >>>> +            .pmc_base_reg = 0x10,
> >>>> +            .pmc_reg = 0x1008,
> >>>> +            .pmc_no_reboot_mask = (1 << 4),
> >>>
> >>> Is that correct? I'm comparing things here to
> >>> linux/drivers/watchdog/iTCO_wdt.c, no_reboot_bit() which seems to
> >>> deliver a mask, not a bit number.
> >> (1<<4) should be equivalent to 0x00000010. However, it seems that you
> are right the value seems to be wrong. The linux kernel uses
> 0x00000002(1<<1) for iTCO v4.
> >>
> >> I'll get the device and do additional tests.
> >> Do you have some test that you'd like me to do to confirm?
> >>
> >
> > Well, the test is simple: Check that the watchdog is firing after the
> > configured time, rebooting the system. To enforce that, you could load
> > a Linux kernel that does not contain an iTCO watchdog driver.
> >
> 
> Already had a chance to check? The Debian community is asking for a new
> release as we have a number of build fixes in master for latest gnuefi, and 
> they
> like to update that. Would be good to have this feature included into the next
> release as well.

We currently have a limited amount of iTCO v4 devices. I sent a request to have 
access to the device, I don't know when I'll get access to it unfortunately.

With that said, if someone have an iTCO v4 and would like to test. I wouldn't 
mind at all.

I know that at some point Arturs Laizans had a device. 
https://groups.google.com/g/efibootguard-dev/c/vejOTECkE3s/m/4OktAjFHBAAJ

Best,

Mathieu


-- 
You received this message because you are subscribed to the Google Groups "EFI 
Boot Guard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to efibootguard-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/efibootguard-dev/YQBP288MB00676DA594BBFA2AF941F06EB7102%40YQBP288MB0067.CANP288.PROD.OUTLOOK.COM.

Reply via email to