This doesn't depend on libdw changes, so I would put it as 2/5.

> +# Make sure there are no unknown DWARF codes.
> +testrun_on_self_nomatch "\?\?\?\ \([x0-9]+\)|lo_user\+0x[0-9a-f]+" 
> ../src/readelf -N -w

There's no need for \ before a space.  Use single-quotes anywhere you
don't have a reason to use double-quotes in a shell script.  It's
especially unclear when using backslashes inside double-quotes, where
some will get stripped and others won't.

Frankly I still think I'd prefer the output be just "%#x" rather than
"??? (%#x)".

> +    if test $grep_ok == 0; then

Single = in test.

> +      exit_status=1;

Superfluous ;.


Thanks,
Roland
_______________________________________________
elfutils-devel mailing list
elfutils-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/elfutils-devel

Reply via email to