Hi Aaron, On Mon, 2026-03-09 at 14:43 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey <[email protected]> > --- > v2: Clarify how to find the size of the symbol table and when ndx must > be zero.
Maybe clarify one little bit about xshndx: > +.TP > +.I xshndx > +Updated extended section index entry to be associated with > +.IR sym . > +Must be zero if > +.I shndxdata > +is NULL. xshndx also should be zero (SHN_UNDEF) when sym->st_shndx != SHN_XINDEX. This implementation doesn't not check that condition however (you are allowed to store a non-zero value in the xindex, but that would result in an inconsistent ELF.) Maybe that is too pedantic though. So you decide :) Cheers, Mark
