Hi Aaron, On Mon, 2026-03-09 at 14:43 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey <[email protected]> > --- > v2: Mention data->d_type must be ELF_T_MOVE and that it's a Sun/Solaris > extension.
This looks good to me, but don't forget that ... > +.TP > +.I src > +Pointer to a caller\-provided move structure. For > +.B ELFCLASS32 > +binaries, > +.B m_info > +and > +.B m_poffset > +should be able to fit within unsigned 32-bit values. > +The > +.B GELF_M_SIZE > +component of > +.B m_info > +should fit in unsigned 8 bits and the > +.B GELF_M_SYM > +component should fit in unsigned 24 bits. > +.I src > +must not be NULL. These restrictions aren't checked in our implementation. And at the moment it contains a bad assert about the 32/64 bit sizes being equal that will always trigger (at runtime). Thanks, Mark
