Jon RFC3986 refers to the process as merging in §5.2 “The pseudocode above refers to a "merge" routine for merging a relative-path reference with the path of the base URI”
But, I’m indifferent about the naming. Andrew > On 19 May 2016, at 02:05, Jon Parise <[email protected]> wrote: > > A minor piece of feedback, but have you considered naming this URI.join/2? > > That would be consistent with similar functions in Python (urlparse.urljoin) > and Ruby (URI.join). > > On Wed, May 18, 2016 at 12:21 PM, Andrew Timberlake > <[email protected] <mailto:[email protected]>> wrote: > Example: > > iex> URI.merge("http://example.com/foo <http://example.com/foo>", "/bar") |> > to_string > "http://example.com/bar <http://example.com/bar>" > > iex> URI.parse("http://example.com/foo <http://example.com/foo>") |> > URI.merge("/bar") |> to_string > "http://example.com/bar <http://example.com/bar>" > > …and more > > I have written the code based on RFC2396 §5.2 and would like to send through > a pull request. > > Andrew > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:elixir-lang-core%[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/C1FD35C2-B4C6-4701-83AC-F0F1FA656E1D%40andrewtimberlake.com > > <https://groups.google.com/d/msgid/elixir-lang-core/C1FD35C2-B4C6-4701-83AC-F0F1FA656E1D%40andrewtimberlake.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/CAPdFhdVX1inBx8TV7Q32rDLYetiydfHXk1isBRWn_GkL2erXhA%40mail.gmail.com > > <https://groups.google.com/d/msgid/elixir-lang-core/CAPdFhdVX1inBx8TV7Q32rDLYetiydfHXk1isBRWn_GkL2erXhA%40mail.gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/C6F3729D-7966-4D25-8D49-C06EA6EB676F%40andrewtimberlake.com. For more options, visit https://groups.google.com/d/optout.
