Having watched the discussion on similar features, I'd say the criteria is something like:
1. Does it allow something that is otherwise not possible 2. Does it substantially reduce the amount of work required for a common use case To me, this would best fit under 2, but doesn't substantially reduce the amount of work required. Allen Madsen http://www.allenmadsen.com On Mon, Sep 18, 2017 at 11:38 AM, Alberto Almagro <[email protected]> wrote: > Thanks guys for stepping in! > > José Valim, maybe people haven't yet stepped in because this proposal is > no rocket science GenServer or the likes ;-) I definitely think it would > contribute to make Elixir more beautiful. Don't you think it expresses much > better the intention of the code if we were able to write String.remove > instead of replacing with white spaces? > > Thanks! > > El lunes, 18 de septiembre de 2017, 16:39:04 (UTC+2), José Valim escribió: >> >> When I am not certain if a feature will be useful, I let the community >> step in. In this case, it seems there is not a lot of interest, which is >> probably a sign that we don't need the feature. In any case, thanks for the >> proposal Alberto Almagro. >> >> Here is also the official place for feature proposals, so we should not >> redirect to the forum. :) >> >> >> >> *José Valimwww.plataformatec.com.br >> <http://www.plataformatec.com.br/>Founder and Director of R&D* >> >> On Mon, Sep 18, 2017 at 4:33 PM, OvermindDL1 <[email protected]> wrote: >> >>> I'd recommend posting this on the forums, it should generate more >>> discussion there and have more visibility. Overall though Jose will look >>> at it here when he gets time. :-) >>> >>> On Monday, September 18, 2017 at 1:16:41 AM UTC-6, Alberto Almagro wrote: >>>> >>>> This has been here almost for a month.... any thoughts guys? >>>> >>>> El viernes, 25 de agosto de 2017, 17:55:09 (UTC+2), Alberto Almagro >>>> escribió: >>>>> >>>>> Hello, >>>>> >>>>> I would like to add String.remove/2 with attributes (subject, pattern) >>>>> to be able to remove patterns from Strings. Now when I want to remove a >>>>> pattern from a String I have to replace it with an empty string like for >>>>> example String.replace(string, " ", ""). While this works, in my opinion >>>>> it >>>>> doesn't give the code the meaning I want. Calling String.remove(string, " >>>>> ") would much better reveal my intention of removing a pattern instead of >>>>> replacing it. >>>>> >>>>> If you agree with this, I would like to make and submit a PR adding >>>>> this feature. If you also want to add some options to it, please tell me >>>>> the ones you think that may be useful. >>>>> >>>>> Thanks in advance for the time you spend reviewing my proposal, >>>>> Alberto >>>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "elixir-lang-core" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit https://groups.google.com/d/ms >>> gid/elixir-lang-core/31d0bc53-9a16-4262-9533-8121e85ec89b% >>> 40googlegroups.com >>> <https://groups.google.com/d/msgid/elixir-lang-core/31d0bc53-9a16-4262-9533-8121e85ec89b%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/elixir-lang-core/e36abd5e-a4e6-4f60-934b- > 8b9e4dd7d61b%40googlegroups.com > <https://groups.google.com/d/msgid/elixir-lang-core/e36abd5e-a4e6-4f60-934b-8b9e4dd7d61b%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAK-y3Cute6nG750hMTjw8MD6iw2ieCXAT_RS1mP%3DzsZu1TL1RQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
