Hi Alberto, please note we won't be accepting this feature as it doesn't offer much on top of replace. Thanks!
*José Valimwww.plataformatec.com.br <http://www.plataformatec.com.br/>Founder and Director of R&D* On Tue, Oct 17, 2017 at 11:54 PM, Alberto Almagro <[email protected]> wrote: > I have implemented a first version of it. What do you think? > https://github.com/elixir-lang/elixir/commit/ > f8ce1c4f066fef26670a9142d347ac6cf99db93a > > Thanks in advance, > Alberto > > > El viernes, 25 de agosto de 2017, 17:55:09 (UTC+2), Alberto Almagro > escribió: >> >> Hello, >> >> I would like to add String.remove/2 with attributes (subject, pattern) to >> be able to remove patterns from Strings. Now when I want to remove a >> pattern from a String I have to replace it with an empty string like for >> example String.replace(string, " ", ""). While this works, in my opinion it >> doesn't give the code the meaning I want. Calling String.remove(string, " >> ") would much better reveal my intention of removing a pattern instead of >> replacing it. >> >> If you agree with this, I would like to make and submit a PR adding this >> feature. If you also want to add some options to it, please tell me the >> ones you think that may be useful. >> >> Thanks in advance for the time you spend reviewing my proposal, >> Alberto >> > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/elixir-lang-core/5883f963-4bdd-40ac-b3d4- > cb9522dbb8cd%40googlegroups.com > <https://groups.google.com/d/msgid/elixir-lang-core/5883f963-4bdd-40ac-b3d4-cb9522dbb8cd%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4KigRONrPFZGa3BF6uC5Qz7aDyQZw3R6TWKkVfp5iAG5A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
