Hi Tonći!

Thanks for your comment. I know that this is possible and I've even 
implemented a formatter that spits out JUnit xml report. 

That is an alternative for sure and one I'd probably use until this is 
built-in. I still think that the current formatter could be better though 
for the reasons I've mentioned before. 

Having a new formatter which only adds this funcionality but is a copy and 
paste of the rest of the source seems not really good but I'll probably go 
on with this suggestion if this is not accepted.

Regards,

Em quarta-feira, 10 de junho de 2020 08:37:01 UTC-3, Tonći Galić escreveu:
>
> Hi Victor,
>
> As far as I know, it's already possible to generate your own formatting 
> with ExUnit.Formatter. 
> You basically tell ExUnit which module should receive events and that 
> module can handle the output/format reporting failure etc.
>
> Some docs/examples:
>   - https://hexdocs.pm/ex_unit/master/ExUnit.Formatter.html#content
>   - example (I'm not affiliated/familiar): 
> https://github.com/victorolinasc/junit-formatter
>
>
> So I think it's not necessary to add a new feature.
>
> Hope it helps,
> Tonći
>
> On Tuesday, June 9, 2020 at 3:07:22 AM UTC+2, Victor Oliveira Nascimento 
> wrote:
>>
>> Hi all! 
>>
>> I'd like to ask if a line limit to ex_unit cli_formatter would be 
>> welcomed in core. This sounds like a super silly feature but it is one that 
>> I think would raise the quality of the tool because:
>>
>> 1. It is easier to know the number of tests run with a quick glance
>> 2. Most shell/console interfaces are vertical and not horizontal 
>> 3. Some shells/consoles have issues with very long lines 
>>
>> I have a proof of concept and was about to open a PR as a draft but 
>> reading through the contributing guide in README this step here is 
>> necessary. In any case, this is not a difficult thing to code :)
>>
>> The *MAIN* reason I am doing this is number 3. I use Emacs and work on a 
>> project that has, currently, around 3 thousand tests. There is a long 
>> history of Emacs not handling this well because, well... let's just say 
>> because Emacs...
>>
>> So, I thought this is pretty simple:
>>
>> - count consecutive non-failures
>> - if it reaches line_limit add a "\n" 
>> - any failures will reset the counter too
>>
>> Here is how it looks for ex_units test suite:
>>
>>
>> So, is this a welcome addition? Should I go on and open a PR?
>>
>> In any case, thanks to the core team for the great work on the platform. 
>>
>> Stay safe, stay home!
>>
>> Regards
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/elixir-lang-core/0cde269a-b5b2-42a0-a86d-a22ba9e95269o%40googlegroups.com.

Reply via email to