One thing you might want to also test is how your code deals with negative numbers. In particular, negative numbers that round to zero!
On Fri, Dec 16, 2016 at 1:42 PM, Nick H <[email protected]> wrote: > There's nothing in the standard libraries (that I know of) to help with > number formatting. There have been a few libraries written, but this > <http://package.elm-lang.org/packages/krisajenkins/formatting/4.0.6/Formatting> > is the only one I see that is up-to-date with 0.18. > > My personal guideline for when to publish something is just whenever I > have something I want to use in multiple projects. Your code solves a > problem... I say publish it! You can always improve or expand it later if > you want. > > The README for elm-package <https://github.com/elm-lang/elm-package> > walks you through the steps of publishing something to the package manager. > In my experience, the elm-package command is pretty user friendly... if you > forget something like documentation, or bumping the version number, it will > let you know. But if there is anything confusing, we'll be happy to clear > it up :-) > > On Fri, Dec 16, 2016 at 12:53 PM, Eduardo Cuducos <[email protected]> > wrote: > >> Hi peeps, >> >> I needed to format some floats (eg. from 1234.56 to 1,234.56) and I >> couldn't find a ready-made solution. I confess I haven't searcher much but >> all I've found was this 3 years old topic >> <https://groups.google.com/forum/#!topic/elm-discuss/mVPrEqWBGKw> from >> this forum, and some 2 years old packages such as Aron's one >> <https://github.com/avh4/elm-number-format>. >> >> This is the solution I wrote >> <https://github.com/datasciencebr/jarbas/blob/b063c888d20778f421515e26341a268d480174a6/jarbas/frontend/elm/Format/Number.elm> >> (not sure about the quality though, I'm still a beginner). There are some >> some >> simple tests >> <https://github.com/datasciencebr/jarbas/blob/b063c888d20778f421515e26341a268d480174a6/jarbas/frontend/tests/elm-tests/Tests.elm#L36-L51> >> too. >> >> The questions are: >> >> - Was it a waste of time writing it all fro scratch? What have I >> missed? >> - If it wasn't… does it worth it to (try to) publish to elm-packages? >> If so, is there a recommended tutorial, documentation about how to pack & >> send it? >> >> Many many thanks, >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Elm Discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Elm Discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
