> OK to install this extra font-locking in lisp/progmodes/tcl.el?
Go for it. AFAIK there's no maintainer for tcl-mode and I've been the most
"active" maintainer for it in the last few years, but my last use of Tcl
goes back many years.
> + (defvar tcl-builtin-list
> + '("after" "append" "array" "bgerror" "binary" "catch" "cd" "clock"
> + "close" "concat" "console" "dde" "encoding" "eof" "exec" "expr"
> + "fblocked" "fconfigure" "fcopy" "file" "fileevent" "flush"
> + "format" "gets" "glob" "history" "incr" "info" "interp" "join"
> + "lappend" "lindex" "linsert" "list" "llength" "load" "lrange"
> + "lreplace" "lsort" "namespace" "open" "package" "pid" "puts" "pwd"
> + "read" "regexp" "registry" "regsub" "rename" "scan" "seek" "set"
> + "socket" "source" "split" "string" "subst" "tell" "time" "trace"
> + "unknown" "unset" "vwait")
Just skimming through it, I notice "namespace". Is it really a builtin?
I would've expected it to be a keyword.
> + (list (concat "\\(\\s-\\|^\\|\\[\\)"
> + (regexp-opt tcl-builtin-list t)
> + "\\(\\s-\\|$\\|\\]\\)")
How 'bout (concat "\\_<" (regexp-opt tcl-builtin-list t) "\\_>") ?
> + '("\\\\$" 0 font-lock-warning-face) ; escaped EOL
Why warning? Is it dangerous? I don't think so.
Also the regexp matched more than escaped EOL, it also matches an escaped
backslash at the end of the line.
I'd rather put a warning face on things like "\\\\[ \t]+$" (although it
should also check to see if the backslash is not escaped).
Stefan
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
