>From my side I confirm the second patch works fine for me so far on current org-mode.
Thank you Gustav, Nikolas! Any chance for this patch to go upstream, please? On 25 November 2015 at 18:39, Gustav Wikström <gus...@whil.se> wrote: > Hi, > > Taking your comments and improving the first patch a bit resulted in the > attached one. It replaces the previous. Using string-prefix-p and > string-suffix-p solves the out of index problem in the substrings. > > BR > Gustav > >> -----Original Message----- >> From: Nicolas Goaziou [mailto:m...@nicolasgoaziou.fr] >> Sent: Wednesday, November 25, 2015 15:53 >> To: Gustav Wikström <gus...@whil.se> >> Cc: emacs-orgmode@gnu.org; sgeorgii . <sgeor...@gmail.com> >> Subject: Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and >> regexps >> >> Gustav Wikström <gus...@whil.se> writes: >> >> > Hmm, since the error was thrown when trying to look at indexes outside >> > of the string in (substring ... ), I don't see how isregexp can be >> > left as is. We have to make sure the substring-code is not evaluated >> > if the tag is empty. What am I missing? >> >> Nothing, I was clear as mud. >> >> (cond >> ((string= "" tag) (setq f1 '(not tags))) >> ((and (equal "{" ...) >> (equal "}"...)) >> ...) >> (t ...)) >> >> Or even >> >> ((and (string-prefix-p "{" ...) >> (string-suffix-p "}" ...))) >> >> on master. >> >> Regards,