Hi, > -----Original Message----- > From: Nicolas Goaziou [mailto:m...@nicolasgoaziou.fr] > Sent: Thursday, November 26, 2015 09:22 > To: Gustav Wikström <gus...@whil.se> > Cc: sgeorgii . <sgeor...@gmail.com>; emacs-orgmode@gnu.org > Subject: Re: [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps > > Gustav Wikström <gus...@whil.se> writes: > > > Taking your comments and improving the first patch a bit resulted in > > the attached one. It replaces the previous. Using string-prefix-p and > > string-suffix-p solves the out of index problem in the substrings.
Ok, darnit. And I see you found another workaround for that ;-) > > Applied. Thank you. Great. > > I modified a bit the patch however, since my suggestion about using `string- > suffix-p' doesn't hold: it isn't compatible with Emacs 24.3. > I also removed a bunch of `setq'. Ok, fair enough. A bit more difficult to follow the code now (in my opinion) but I guess it saves a few I/O's. There was a small error in your edit though. The push-statement feels lonely outside of the let*. > > > Regards, Kind regards Gustav
