On 2018-09-02, at 16:50, Marcin Borkowski <mb...@mbork.pl> wrote:
> On 2018-09-02, at 14:45, Nicolas Goaziou <m...@nicolasgoaziou.fr> wrote: > >> Hello, >> >> Marcin Borkowski <mb...@mbork.pl> writes: >> >>> I attach a trivial patch fixing a very annoying cap on >>> org-clock-history. (I want to set org-clock-history to 120.) >> >> According to 7972356d092736af06282a09f008c2b5f938134d and >> 77f1f31c99f521751dc0b57f9923773e97644bb5, this limits selection to >> standard selection keys. >> >> If we want to allow more clock history, we need to remove the selection >> keys, and be sure we have something else to use. > > I decided to put a warning about this in the docstring in my patch. My > assumption was that this is enough. If a user wants to change the > default, he will most probably see the docstring and will have to > actively ignore the warning. > > I do not use the vanilla Org way of selecting tasks to clock from > history - I use org-mru-clock, for which the restriction doesn't make > sense. So we have something else to use, and it doesn't bother me that > I can't select older tasks with the original Org method. Hi Nicolas and others, any comments on this patch? Best, -- Marcin Borkowski http://mbork.pl
