On 2018-09-06, at 16:18, Nicolas Goaziou <m...@nicolasgoaziou.fr> wrote:
> Hello, > > Marcin Borkowski <mb...@mbork.pl> writes: > >> I decided to put a warning about this in the docstring in my patch. My >> assumption was that this is enough. If a user wants to change the >> default, he will most probably see the docstring and will have to >> actively ignore the warning. > > I don't think this is enough. As you put it, it instills doubt without > explaining anything. Why 35? Why "may not work"? What "may not work"? OK. How about 1. making the docstring more precise 2. leaving the limit, but instead of hard-coded 35 make it configurable using a variable? >> I do not use the vanilla Org way of selecting tasks to clock from >> history - I use org-mru-clock, for which the restriction doesn't make >> sense. So we have something else to use, > > I meant "have something else to use out of the box". I.e., not with an > external library. I see. Frankly, I think the out-of-the-box way of selecting tasks from history is not very good. For starters, it won't work with completion (like org-mru-clock does). Also, I think the window with the list in not scrollable. > I agree with the idea of removing this limitation, but I'm not convinced > your patch is ideal yet. Thanks. I'll submit a better one soon. -- Marcin Borkowski http://mbork.pl
