Max Nikulin <maniku...@gmail.com> writes: >>> I do not like repeating of `org-encode-time' but do not see another way >>> till Emacs-29 will become the lowest supported version. >> >> This is fine. AFAIK, other parts of time handling code is full of conds >> and pcases. > > I mean that before my patch there was single `encode-time' outside of > `pcase', I replace `list' by `org-encode-time' inside each pattern.
I do not see it is a big deal. At least, readability of the code did not degrade, IMHO. >>>> + (org-encode-time >>>> + (apply #'list >>>> + (or (car time0) 0) >>>> + (+ (if (eq timestamp? 'minute) n 0) (nth 1 time0)) >>>> + (+ (if (eq timestamp? 'hour) n 0) (nth 2 time0)) >>>> + (+ (if (eq timestamp? 'day) n 0) (nth 3 time0)) >>>> + (+ (if (eq timestamp? 'month) n 0) (nth 4 time0)) >>>> + (+ (if (eq timestamp? 'year) n 0) (nth 5 time0)) >>>> + (nthcdr 6 time0)))) >>>> (when (and (memq timestamp? '(hour minute)) >>>> extra >>>> (string-match "-\\([012][0-9]\\):\\([0-5][0-9]\\)" extra)) > > From my point of view > > (cl-mapcar > (lambda (value part) > (if (and part (eq part timestamp?)) > (+ n value) > value)) > time0 '(second minute hour day month year nil nil nil)) > > is better than the original code, but... > > Nicolas Goaziou to emacs-orgmode. [Patch] to correctly sort the items > with emphasis marks in a list. Mon, 19 Apr 2021 18:08:17 +0200. > https://list.orgmode.org/87r1j6b6ku....@nicolasgoaziou.fr > > >> I stay away from CL as much as possible, otherwise newcomers will have >> to learn two languages to start contributing, Elisp and CL (cl-loop, >> ewww). CL is still necessary however, as we cannot use `seq' yet. I think that Nicolas was mostly referring to things like cl-loop, which introduce a whole new piece of language concepts into Elisp. cl-mapcar is merely a convenience function. Just as any other Elisp function. It behaves without surprises within the general Elisp programming concepts. I do not see why we should not use it if it improves the code clarity. Best, Ihor
