Evgenii Klimov <eugene....@lipklim.org> writes: > ...
Thanks for the update. Few comments. First, please add Changelog entry for etc/ORG-NEWS. > +(defvar org-metaleft-final-hook nil > + "Hook for functions attaching themselves to `M-left'. > +See `org-ctrl-c-ctrl-c-hook' for more information.") Note that unlike the docstring your added, `org-shiftup-final-hook' specifies when the hook is executed: (defvar org-shiftup-final-hook nil "Hook for functions attaching themselves to `S-up'. This one runs after all other options except shift-select have been excluded. See `org-ctrl-c-ctrl-c-hook' for more information.") It is better to follow the pattern and clarify the purpose of the hook better instead of leaving docstrings for both the -final and other hook same. > +individual commands for more information. > + > +This function runs the hook `org-shiftmetaleft-hook' as a first > +step, `org-shiftmetaleft-final-hook' as the penultimate step, and > +returns at first non-nil value." Upon looking closer, I realized that you also defined return value of the function here. Is there any particular reason for this? The return value is currently not defined and supposed to be discarded. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
