Max Nikulin <maniku...@gmail.com> writes:

> On 30/07/2023 16:16, Ihor Radchenko wrote:
>> The problem with dependencies is only there for local builds and that's
>> probably the motivation of the `condition-case' I proposed to change in
>> my patch.
>
> Worg is a set of independent documents, so fail on first error in CI is 
> reasonable mostly only if a commit may be pushed to the main branch when 
> it can be built cleanly (a kind of pre-commit check). Otherwise a 
> contributor may have to struggle with a problem introduced by another 
> person in a completely unrelated file.

Fair point.

> I am unsure if another workflow is suitable for Worg and SourceHut: 
> changes are pushed to branches. A branch can be merged only if it can be 
> built successfully. With such approach fail of first error may work.
>
> I hope, there is a better way to address the issue with failure 
> notifications.

That sounds too complex.
I think we can simply add an extra "check" task to
https://git.sr.ht/~bzg/worg/tree/master/item/.build.yml
It will run after "upload", re-exporting files, but not ignoring errors
this time.
WDYT?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to