> From: Eli Zaretskii <e...@gnu.org> > Date: Wed, 2023-09-06 15:16 +0300 > >> From: Ihor Radchenko <yanta...@posteo.net> >> Date: Wed, 06 Sep 2023 08:23:23 +0000 >> >> Eli Zaretskii <e...@gnu.org> writes: >> >> >> The following would do it. I think I tested it rather thoroughly. >> >> During testing I found another bug that is addressed by the let-binding >> >> of kill-read-only-ok during the first kill-region below. >> > >> > Thanks. Sadly, we don't have any tests for this function in our test >> > suite, so verifying this non-trivial change will not be easy... >> >> Then, what should we do to move things forward? I guess the first step >> will be writing these missing tests. > > Yes, that'd be most welcome.
I will write the tests. And I will probably come up with an updated version of the original patch. There is at least one cosmetic change. And something else that I want to have tried. May take some time. >> Anything else? > > How about asking on emacs-devel that people who use kill-whole-line > frequently install the patch and run with it for some time? (We could > do that after installing the changes on master, of course.)
