Buoso Donati <poverobuosodon...@gmail.com> writes: > Are there any objections against me trying to upstream this addition?
C# is a popular language. I have no objections to adding it to the core. > ... I would go ahead and try to open a pull request following the > guidelines from this documentation > (https://orgmode.org/worg/org-contribute.html) if there are none. Or > is there a better way/no need for it in the first place? If you can, please do follow what is written in our contribution guide. But feel free to ask us anything if you encounter difficulties. You do not have to go through all the requirements alone. > In fact, I was most inspired by the existing ob-C.el and ob-java.el! > From what I understand C# (in conjunction with csproj-files) is > "different enough" from C/C++ and Java (I don't feel particularly > comfortable judging the D language) that it somewhat makes sense to > create an individual file integrating it (as opposed to increase the > complexity with existing integrations). > I will however consider this and re-evaluate my initial concept with > your feedback. Generally, it only makes sense to extend an existing library if there is very significant code sharing. Otherwise, no need to complicate things. Also, before you proceed, note that there is ob-csharp in org-contrib repository: https://git.sr.ht/~bzg/org-contrib/tree/master/item/lisp/ob-csharp.el It is very simplistic though. Just letting you know so that you are aware. You do not need to reuse that file or anything like that - we *cannot* use that file because its author did not sign copyright papers. (BTW, you do need to do it - let me know if you need any assistance) After your future patch is accepted, we will likely remove ob-csharp from org-contrib. Which means that you should name the new library ob-csharp as well - it will serve as the replacement. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
