Karthik Chikmagalur <karthikchikmaga...@gmail.com> writes:
> I would like to submit the org-latex-preview patchset for review and
> merging now. I will be losing my FSF copyright assignment soon, so I'm
> hoping to see it merged before then even if there are some minor issues
> remaining to be addressed.
Sure. Let's get started.
> Another reason is that the main branch is slowly adding changes
> incompatible with the patchset, such as the recent addition of xelatex
> as an entry in `org-preview-latex-process-alist'. I think this change
> doesn't make sense even by itself -- it is a category error to place
> this configuration in this alist -- but in any case we offer more
> comprehensive support for both xetex and lualatex in the patchset, in
> that you can use any combination of
>
> {xelatex, lualatex} X {dvipng, dvisvgm, imagemagick}
>
> along with several other configuration options.
I agree. But that change was still an improvement compared to the
existing state of affairs. It will become unnecessary after this merge.
> The last major blocker for the patchset is updating
> `org-babel-execute:latex', which is broken in Tecosaur's branch. I am
> trying to fix it now, but this function is a big mess, and I need your
> help. I will send a separate email with questions about this function.
As a general comment, do remember that ob-latex by itself is buggy. We
should not be afraid too much to keep things bug-compatible here.
That said, we should try to keep what is written in
https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-LaTeX.html
working as described.
> I'm fixing linting and byte-compilation errors right now. Would you
> like the updated Org manual to be included in the patchset, or should I
> wait to update it until we have the merge-related discussions? There
> are many, many improvements across the board to Org's LaTeX handling, so
> the manual and NEWS require a lot of work.
Up to you. A general description of the new features would be welcome in
any case - it will make things easier for me during the review. That
description may serve as a good guideline for manual/news page later.
>> One of the new core mechanisms introduced in the patch is the
>> "feature" system for building export preambles. It allows building the
>> preambles selectively, depending on the document contents and current
>> export configuration.
>
> Tecosaur is busy with other projects, so I don't think your feeback on
> the features/templates system will be incorporated in time. I'm not
> familiar enough with the design or the intent to work on this.
>
> The new LaTeX preview system is almost completely independent of the
> export features system, so I think this patchset can be split and just
> the LaTeX preview features submitted first.
>
> The only overlap between the two is a single LaTeX preamble generation
> function for previews, which can be replaced.
I do not mind. If we can move forward in smaller steps, let us do it.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
