>> I would like to submit the org-latex-preview patchset for review and >> merging now. I will be losing my FSF copyright assignment soon, so I'm >> hoping to see it merged before then even if there are some minor issues >> remaining to be addressed. > > Sure. Let's get started.
I have a question about addressing byte-compile warnings, explained via example: 1. In the preview branch, org-create-formula-image has been moved to org-compat.el since it is obsolete. 2. This function uses org--get-display-dpi, which has also been made obsolete: (define-obsolete-function-alias 'org--get-display-dpi 'org-latex-preview--get-display-dpi "9.8") 3. I get the following byte-compile error in org-create-formula-image: org-compat.el:1031:62: Warning: ‘org--get-display-dpi’ is an obsolete function (as of 9.7); use ‘org-latex-preview--get-display-dpi’ instead. To address this warning, should I replace org--get-display-dpi with org-latex-preview--get-display-dpi in org-create-formula-image? After moving them to org-compat, I've left obsoleted functions untouched so far. Karthik
