Ihor Radchenko <[email protected]> writes:

> Applied, onto main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=50de2f717
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8fceda647
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4611c2b7a

:D

> Multi-patch commits are not very common

The GNU Guix folk have trained me to make small commits.  Expect lots of
multi-patch commits from me :)

>> If I remeber correctly John Wiegley posted on their blog
>> (https://newartisans.com/) something about experimenting with git commit
>> hooks to ensure tests are run at every stage.
>
> In theory, such tests could be done on CI. But adding this kind of
> feature to CI tests will require work that may or may not be justified.
>
>> If I remember correctly though he wasn't able to make it work for
>> rebasing which is how I made these patches :/.
>
> What exactly was the problem?

https://newartisans.com/2009/02/building-a-better-pre-commit-hook-for-git/

https://newartisans.com/2009/02/the-saga-of-rebase-versus-merge/


I haven't actually tried implementing any of this and the blog posts
date back to 2009 so there might be easy fixes for these issues
available now.

In the first link John Wiegley describes the issue with creating the
pre-commit hook in the first place (wanting to test only the commit made
while having a dirty worktree).

In the second link he discovers his solution is inadequate for his
workflow as the hooks aren't run on rebase.

Reply via email to