Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=50de2f717 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8fceda647 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4611c2b7a
Morgan Smith <[email protected]> writes: > Nice catch! Time to start a checklist of things to do before submission > which includes test each invididual patch. Do we have a checklist > somewhere? https://orgmode.org/worg/org-contribute.html#devs There is nothing overly complex described there. As for testing individual patches, it is usually not a problem. Multi-patch commits are not very common, so there was never a need for automation in this area. For large new features that have to start on a separate branch, testing every commit is often not productive (it takes a lot of time). My comment was more or less an accident find when I was looking at the diff. > If I remeber correctly John Wiegley posted on their blog > (https://newartisans.com/) something about experimenting with git commit > hooks to ensure tests are run at every stage. In theory, such tests could be done on CI. But adding this kind of feature to CI tests will require work that may or may not be justified. > If I remember correctly though he wasn't able to make it work for > rebasing which is how I made these patches :/. What exactly was the problem? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
