Sam Crawford <[email protected]> writes: > I did send off the form for FSF copyright assignment, but haven't heard > back yet. (Any idea how long this process usually takes?)
They should generally reply within a week. If there is no reply for over a month, I can write to them to push things forward. When did you send the assignment? >> Please, add a docstring. Here, and in all other new functions. > > Sorry about that! Docstrings added. Almost :) You need to mention all the arguments in the docstring. Still not the case in `org-babel-load-session:scheme'. (try M-x checkdoc) >> Any specific reason why you set things up differently from >> `org-babel-scheme-execute-with-geiser': > > The `org-babel-scheme-execute-with-geiser' set-up still seems to > display > the buffer in the current window. My understanding is that > `org-babel-initiate-session' shouldn't affect what windows are > displayed, rather it should just return the session buffer. Does it mean that normal block evaluation spawns a new window now? > * lisp/ob-scheme.el (org-babel-execute:scheme): > (org-babel-scheme--get-impl): Extract logic for determining impl as > its own function > (org-babel-scheme-initiate-session): > (org-babel-prep-session:scheme): > (org-babel-load-session:scheme): Added. Implementations similar to > those of other languages (e.g. ob-R) > > These new functions make org-babel-pop-to-session and friends work > correctly. Also, few nitpicks since we are not committing this patch yet: 1. Please end sentences with "." 2. Please quote Elisp symbols as `symbol'. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
