Sam <[email protected]> writes: > Ihor Radchenko <[email protected]> writes: > >> I am just worried that those changes might be necessary for geiser to >> function. (The main problem for us is that geiser is not really designed >> to be used the way Org mode uses it) >> >> Although, looking into the uses of `geiser-repl--switch-to-buffer' in >> geiser code, it does not seem to be an issue - no special fiddling with >> window configuration seems to be going on. > > Yes, I think we're safe for now. I might even go as far as to submit a > patch to geiser separating out the logic for creating the REPL buffer > from the logic for displaying it. Even though it wouldn't change the > situation for ob-scheme any time soon, it might provide some security in > the future. > >> However, I think that it is better if you move all the setup for window >> suppression into `org-babel-scheme-get-repl'. > > I've added a new patch before the original that moves the window > suppression from `org-babel-scheme-execute-with-geiser' to > `org-babel-scheme-get-repl' and adds my own. The patch with new > functions no longer has any of this setup. Brief testing on my end > suggests it works as intended. > >> Also, what about `save-window-excursion' in `org-babel-load-session:scheme'? > > Removed. I don't think it was necessary anyway.
Applied, onto main, with minor amendments to the commit messages, after adding one missing docstring. Thanks! https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21516ce00 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=876e6947c -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
