>>>>> Ihor Radchenko <[email protected]> writes:
> Some comments:
>
> 1. Looks like you always calculate all TBLFM lines, which is not the
> default that vanilla calculator uses.
> 2. You are calling org-table-align unconditionally, even if no changes
> are made. It *will* slow things down on long complex tables.
> 3. "Double definition `%s=' in TBLFM line, please fix by hand" notice is
> missing
> 4. Named fields does not seem to be supported. There is
> org-table-loeb--current-env but it is not used at all.
> 5. "A3" reference format does not seem to be supported
> 6. remote references does not seem to be supported
> 7. + ;; Replace --matrix-- and --row-map-- with proper bindings
> + (fixed (replace-regexp-in-string
> + "--row-map--" "the-row-map"
> + (replace-regexp-in-string
> + "--matrix--" "the-matrix" substituted)))
> Why??
> 8. No formatting support. No support for empty cell values.
>
> I suggest running your patch through standard org-table tests.
All of this should be done now:
┌─────┬──────────────────────┬────────────┬────────────────────────────────────────────┐
│ # │ Comment │ Status │ Evidence
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 1 │ TBLFM line │ │ Uses org-table-get-stored-formulas
(line │
│ │ calculation │ ADDRESSED │ 951)
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 2 │ Conditional │ │ Compares original vs new content
(lines │
│ │ org-table-align │ ADDRESSED │ 946, 961-966)
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 3 │ Double definition │ │ Delegated to
org-table-get-stored-formulas │
│ │ notice │ ADDRESSED │
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 4 │ Named fields support │ │ Uses
org-table-formula-substitute-names │
│ │ │ ADDRESSED │ (lines 712-716)
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 5 │ A3 reference format │ │ Uses org-table-convert-refs-to-rc
(lines │
│ │ │ ADDRESSED │ 704-708)
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 6 │ Remote references │ │ org-table-loeb--expand-remote-refs
(lines │
│ │ │ ADDRESSED │ 242-263)
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 7 │ Weird --matrix-- │ NOT │ Current code uses clean cl-progv
binding │
│ │ replacement │ PRESENT │
│
├─────┼──────────────────────┼────────────┼────────────────────────────────────────────┤
│ 8 │ Formatting/empty │ │ Full implementation (lines 422-566)
│
│ │ cells │ ADDRESSED │
│
└─────┴──────────────────────┴────────────┴────────────────────────────────────────────┘
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
