Sławomir Grochowski <[email protected]> writes: > My plan for the near future is to focus on refactoring org-colview.el, > so you should expect a fair number of commits from me touching that > file. I'll do my best to keep changes well-scoped and reviewable rather > than dumping large patches all at once. I prefer small, focused commits, > and that's how I intend to work here.
Refactoring would be certainly welcome. I myself plan to focus on refactoring once the dust settles with the new contributor liaisons and I can free time for more than bugs and patches. > This is my first time maintaining a file in Org / Emacs, so I would be > genuinely grateful for any guidance — both on the code itself > (conventions, things to watch out for in column view that aren't obvious > from the source) and on the maintainer role more broadly (workflow > expectations, anything I should be aware of). We should mostly have the conventions documented in https://orgmode.org/worg/org-contribute.html. Otherwise, stick to Elisp conventions: https://www.gnu.org/software/emacs/manual/html_node/elisp/Tips.html Maintainers are also expected to take care about reports concerning the library they maintain. Contributor liaisons will redirect relevant reports as needed. And, of course, you can decide about new features and changes within the library. Just make sure to stick to general guidelines (https://orgmode.org/worg/org-maintenance.html#guidelines) and consider discussing significant changes on the list, especially changes that may affect other libraries in Org. See also https://orgmode.org/worg/org-maintenance.html#maintainer-role Here are some reports related to column view that I have in my notes: 1. https://list.orgmode.org/orgmode/871qh5wpo6.fsf@localhost/ 2. https://list.orgmode.org/orgmode/87jyuwxfot.fsf@localhost/ 3. in org-agenda, when column view is active, the columns are not updated when the filter is changed 4. https://list.orgmode.org/orgmode/87il1z3a2p.fsf@localhost/ 5. https://www.reddit.com/r/orgmode/comments/12edbkv/agenda_column_view_noneditable/ 6. https://list.orgmode.org/orgmode/[email protected]/ 7. https://list.orgmode.org/orgmode/[email protected]/ 8. https://list.orgmode.org/orgmode/[email protected]/ 9. https://list.orgmode.org/orgmode/[email protected]/ 10. https://list.orgmode.org/orgmode/[email protected]/ > Feedback on patches once they start landing — even blunt feedback — will > be very welcome. Thanks, and looking forward to working with you. I generally review all the new commits. At least, skim through. If you want detailed feedback for some patch, you can post it to the list, so that others know that you want comments. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
