PavoDive <[email protected]> writes:

> I kept on working on the idea that a minor change to
> org-activate-links was a simple, yet good solution, and propose that
> adding an overlay to the visible part of the link (inside the comment)
> will allow us to set a different face. This spares us from the
> precedence that font-lock-comment-face takes over almost everything
> else, and still allows us a link inside a comment line that will be
> distinguishable and actionable (both via keyboard and mouse).

Thanks! This sounds like what I'd want. Let's see what the maintainer
says, but here are a few things I spotted that you may want to look at
first:

In org-faces.el:

> +(defface org-link-comment-face

With one exception, none of the other face names in org-faces.el end in
"-face". (Exception: org-agenda-dimmed-todo-face, for some reason.)

>  '((t :inherit (org-link)))
>  "Face for Org links that appear inside comment lines.
> Inherits from both `org-link' and `font-lock-comment-face' 

Great, but I think you forgot to add font-lock-comment-face to the
:inherit list (where I think it needs to go first to work).

In org.el:

> (when (save-excursion (goto-char start) (org-at-comment-p))

I think you can make do with

  (when (org-at-comment-p)

Regards,
Christian

Reply via email to