On 2026-05-12 22:29, Jens Schmidt wrote:
> On 2026-05-04 05:09, J.D. Smith wrote:
>
>> [...]
>
> - Please allow setting `org-inside-appearance' to nil. With o-i-t-h
> in place that setting does make sense, IMHO. And if I first switch
> on o-i-m and then set o-i-a to nil, things work as I'd like to have
> them: No automatic effects at all, but o-i-t-h makes the markers
> temporarily visible.
I've seen your latest commit 14c633598, which seems to address above
item (thanks). However, you would also need to change that test in
`o-i-m' that otherwise rejects a nil `o-i-a' as "malformed", wouldn't
you? Like this:
@@ -292,9 +292,8 @@ what appearance changes occur."
:global nil
(cond
((and org-inside-mode
- (not (and org-inside-appearance
- (cl-loop for key in org-inside-appearance by #'cddr
- always (memq key '(:cursor :face :unhide))))))
+ (not (cl-loop for key in org-inside-appearance by #'cddr
+ always (memq key '(:cursor :face :unhide)))))
(setq org-inside-mode nil)
(user-error "`org-inside-appearance' malformed"))
(org-inside-mode (org-inside--setup))
Furthermore, there is still an issue with `org-inside--reset-all'.
In a "make repro" with Emacs 30.2, then M-x load-library org-inside
RET, I get:
Debugger entered--Lisp error: (void-function org-inside--reset-all)
(org-inside--reset-all)
#f(lambda (sym val) [t] (set-default-toplevel-value sym val)
(org-inside--reset-all))(org-inside-appearance (:cursor bar))
custom-initialize-reset(org-inside-appearance (funcall #'#f(lambda () [t] ""
'(:cursor bar))))
custom-declare-variable([...])
load-with-code-conversion("/home/jschmidt/work/org-mode/lisp/org-inside.el"
"/home/jschmidt/work/org-mode/lisp/org-inside.el" nil nil)
load-library("org-inside")
funcall-interactively(load-library "org-inside")
command-execute(load-library record)
execute-extended-command(nil "load-library" "load-lib")
funcall-interactively(execute-extended-command nil "load-library" "load-lib")
command-execute(execute-extended-command)
I guess you have to move `org-inside--reset-all' before the defcustom.
Alternatively, you might want to use something like this snippet from
org-duration.el:
:set (lambda (var val)
(set-default-toplevel-value var val)
;; Avoid recursive load at startup.
(when (featurep 'org-duration)
(org-duration-set-regexps)))
Finally, could you please give me short feedback whether or not
you intend to address more of my requests/questions from
https://list.orgmode.org/[email protected]/T/#mbb1355871f5373ad53fb5554341ab3f5eddc29a8
If yes, I'd wait with that before continuing tests.
Thanks!
