Bastien Guerry <[email protected]> writes: > Ihor Radchenko <[email protected]> writes: > >> The full paragraph I added says >> >> The test suite is designed to ensure stability of Org mode code base >> as it evolves, being modified by numerous contributors. The tests are >> usually designed aiming to ensure the *expected* Org mode behavior. >> Thus, we should not add the tests that just mechanically check what >> the current implementation does. In particular, we should avoid (or, >> at least, explicitly mark) the tests that simply check for some >> arbitrary behavior related to the details of the implementation; not >> to the original design goals. The only exception is when users get >> used to certain ways the code behaves by muscle memory. >> >> So, if Slawomir insists, it is ok to put the tests like in the commit. >> But they should be marked. > > I know. > > I still believe that if too many of these "tests" are added, they will > become a maintenance burden. It seems better to spend time defining the > correct behaviour and testing for it than testing the current behaviour > without knowing if it's correct.
I agree about "too many". However, we currently have insufficient test coverage, so I prioritize having tests over not having tests because we are too picky. I did discourage tests that do not test for indented behavior, but I do not want to kill the momentum for Morgan and more recently Slawomir, who contributed a lot of new tests. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
